VencordToolbox: don't subscribe to all settings
Also remove one indirection from useSettings
This commit is contained in:
parent
102842d528
commit
1c1d82f9a8
|
@ -223,13 +223,13 @@ export const Settings = makeProxy(settings);
|
|||
export function useSettings(paths?: UseSettings<Settings>[]) {
|
||||
const [, forceUpdate] = React.useReducer(() => ({}), {});
|
||||
|
||||
const onUpdate: SubscriptionCallback = paths
|
||||
? (value, path) => paths.includes(path as UseSettings<Settings>) && forceUpdate()
|
||||
: forceUpdate;
|
||||
if (paths) {
|
||||
(forceUpdate as SubscriptionCallback)._paths = paths;
|
||||
}
|
||||
|
||||
React.useEffect(() => {
|
||||
subscriptions.add(onUpdate);
|
||||
return () => void subscriptions.delete(onUpdate);
|
||||
subscriptions.add(forceUpdate);
|
||||
return () => void subscriptions.delete(forceUpdate);
|
||||
}, []);
|
||||
|
||||
return Settings;
|
||||
|
@ -253,8 +253,10 @@ type ResolvePropDeep<T, P> = P extends "" ? T :
|
|||
export function addSettingsListener<Path extends keyof Settings>(path: Path, onUpdate: (newValue: Settings[Path], path: Path) => void): void;
|
||||
export function addSettingsListener<Path extends string>(path: Path, onUpdate: (newValue: Path extends "" ? any : ResolvePropDeep<Settings, Path>, path: Path extends "" ? string : Path) => void): void;
|
||||
export function addSettingsListener(path: string, onUpdate: (newValue: any, path: string) => void) {
|
||||
if (path)
|
||||
if (path) {
|
||||
((onUpdate as SubscriptionCallback)._paths ??= []).push(path);
|
||||
}
|
||||
|
||||
subscriptions.add(onUpdate);
|
||||
}
|
||||
|
||||
|
|
|
@ -30,7 +30,7 @@ import type { ReactNode } from "react";
|
|||
const HeaderBarIcon = findExportedComponentLazy("Icon", "Divider");
|
||||
|
||||
function VencordPopout(onClose: () => void) {
|
||||
const { useQuickCss } = useSettings();
|
||||
const { useQuickCss } = useSettings(["useQuickCss"]);
|
||||
|
||||
const pluginEntries = [] as ReactNode[];
|
||||
|
||||
|
|
Loading…
Reference in a new issue