From 21318850b1df7f945736dcfa00b25947b8f9d718 Mon Sep 17 00:00:00 2001 From: Ryan Cao <70191398+ryanccn@users.noreply.github.com> Date: Sat, 5 Aug 2023 02:13:53 +0800 Subject: [PATCH] fix: open links externally in Quick CSS editor (#1487) Co-authored-by: V --- src/main/ipcMain.ts | 4 +++ src/main/utils/externalLinks.ts | 48 +++++++++++++++++++++++++++++++++ 2 files changed, 52 insertions(+) create mode 100644 src/main/utils/externalLinks.ts diff --git a/src/main/ipcMain.ts b/src/main/ipcMain.ts index 1dcb17c92..c86268dd0 100644 --- a/src/main/ipcMain.ts +++ b/src/main/ipcMain.ts @@ -31,6 +31,7 @@ import monacoHtml from "~fileContent/../components/monacoWin.html;base64"; import { getThemeInfo, stripBOM, UserThemeHeader } from "./themes"; import { ALLOWED_PROTOCOLS, QUICKCSS_PATH, SETTINGS_DIR, SETTINGS_FILE, THEMES_DIR } from "./utils/constants"; +import { makeLinksOpenExternally } from "./utils/externalLinks"; mkdirSync(SETTINGS_DIR, { recursive: true }); mkdirSync(THEMES_DIR, { recursive: true }); @@ -143,5 +144,8 @@ ipcMain.handle(IpcEvents.OPEN_MONACO_EDITOR, async () => { sandbox: false } }); + + makeLinksOpenExternally(win); + await win.loadURL(`data:text/html;base64,${monacoHtml}`); }); diff --git a/src/main/utils/externalLinks.ts b/src/main/utils/externalLinks.ts new file mode 100644 index 000000000..dfe7a7c3a --- /dev/null +++ b/src/main/utils/externalLinks.ts @@ -0,0 +1,48 @@ +/* + * Vencord, a modification for Discord's desktop app + * Copyright (c) 2023 Vendicated and contributors + * + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation, either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see . +*/ + +import { type BrowserWindow, shell } from "electron"; + +export function makeLinksOpenExternally(win: BrowserWindow) { + win.webContents.setWindowOpenHandler(({ url }) => { + switch (url) { + case "about:blank": + case "https://discord.com/popout": + case "https://ptb.discord.com/popout": + case "https://canary.discord.com/popout": + return { action: "allow" }; + } + + try { + var { protocol } = new URL(url); + } catch { + return { action: "deny" }; + } + + switch (protocol) { + case "http:": + case "https:": + case "mailto:": + case "steam:": + case "spotify:": + shell.openExternal(url); + } + + return { action: "deny" }; + }); +}