MoreUserTags: fix settings ui logic

Co-authored-by: Vendicated <vendicated@riseup.net>
This commit is contained in:
Nuckyz 2024-08-23 20:09:58 -03:00
parent 6659f2c413
commit 7ec842d4b0
No known key found for this signature in database
GPG key ID: 440BF8296E1C4AD9
3 changed files with 13 additions and 22 deletions

View file

@ -230,6 +230,10 @@ export function definePluginSettings<
if (!definedSettings.pluginName) throw new Error("Cannot access settings before plugin is initialized"); if (!definedSettings.pluginName) throw new Error("Cannot access settings before plugin is initialized");
return Settings.plugins[definedSettings.pluginName] as any; return Settings.plugins[definedSettings.pluginName] as any;
}, },
get plain() {
if (!definedSettings.pluginName) throw new Error("Cannot access settings before plugin is initialized");
return PlainSettings.plugins[definedSettings.pluginName] as any;
},
use: settings => useSettings( use: settings => useSettings(
settings?.map(name => `plugins.${definedSettings.pluginName}.${name}`) as UseSettings<Settings>[] settings?.map(name => `plugins.${definedSettings.pluginName}.${name}`) as UseSettings<Settings>[]
).plugins[definedSettings.pluginName] as any, ).plugins[definedSettings.pluginName] as any,

View file

@ -22,7 +22,7 @@ import { Devs } from "@utils/constants";
import { Margins } from "@utils/margins"; import { Margins } from "@utils/margins";
import definePlugin, { OptionType } from "@utils/types"; import definePlugin, { OptionType } from "@utils/types";
import { findByCodeLazy, findLazy } from "@webpack"; import { findByCodeLazy, findLazy } from "@webpack";
import { Card, ChannelStore, Forms, GuildStore, PermissionsBits, Switch, TextInput, Tooltip, useState } from "@webpack/common"; import { Card, ChannelStore, Forms, GuildStore, PermissionsBits, Switch, TextInput, Tooltip } from "@webpack/common";
import type { Permissions, RC } from "@webpack/types"; import type { Permissions, RC } from "@webpack/types";
import type { Channel, Guild, Message, User } from "discord-types/general"; import type { Channel, Guild, Message, User } from "discord-types/general";
@ -107,14 +107,8 @@ const defaultSettings = Object.fromEntries(
tags.map(({ name, displayName }) => [name, { text: displayName, showInChat: true, showInNotChat: true }]) tags.map(({ name, displayName }) => [name, { text: displayName, showInChat: true, showInNotChat: true }])
) as TagSettings; ) as TagSettings;
function SettingsComponent(props: { setValue(v: any): void; }) { function SettingsComponent() {
settings.store.tagSettings ??= defaultSettings; const tagSettings = settings.store.tagSettings ??= defaultSettings;
const [tagSettings, setTagSettings] = useState(settings.store.tagSettings as TagSettings);
const setValue = (v: TagSettings) => {
setTagSettings(v);
props.setValue(v);
};
return ( return (
<Flex flexDirection="column"> <Flex flexDirection="column">
@ -137,19 +131,13 @@ function SettingsComponent(props: { setValue(v: any): void; }) {
type="text" type="text"
value={tagSettings[t.name]?.text ?? t.displayName} value={tagSettings[t.name]?.text ?? t.displayName}
placeholder={`Text on tag (default: ${t.displayName})`} placeholder={`Text on tag (default: ${t.displayName})`}
onChange={v => { onChange={v => tagSettings[t.name].text = v}
tagSettings[t.name].text = v;
setValue(tagSettings);
}}
className={Margins.bottom16} className={Margins.bottom16}
/> />
<Switch <Switch
value={tagSettings[t.name]?.showInChat ?? true} value={tagSettings[t.name]?.showInChat ?? true}
onChange={v => { onChange={v => tagSettings[t.name].showInChat = v}
tagSettings[t.name].showInChat = v;
setValue(tagSettings);
}}
hideBorder hideBorder
> >
Show in messages Show in messages
@ -157,10 +145,7 @@ function SettingsComponent(props: { setValue(v: any): void; }) {
<Switch <Switch
value={tagSettings[t.name]?.showInNotChat ?? true} value={tagSettings[t.name]?.showInNotChat ?? true}
onChange={v => { onChange={v => tagSettings[t.name].showInNotChat = v}
tagSettings[t.name].showInNotChat = v;
setValue(tagSettings);
}}
hideBorder hideBorder
> >
Show in member list and profiles Show in member list and profiles
@ -183,7 +168,7 @@ const settings = definePluginSettings({
tagSettings: { tagSettings: {
type: OptionType.COMPONENT, type: OptionType.COMPONENT,
component: SettingsComponent, component: SettingsComponent,
description: "fill me", description: "fill me"
} }
}); });

View file

@ -309,6 +309,8 @@ export interface DefinedSettings<
> { > {
/** Shorthand for `Vencord.Settings.plugins.PluginName`, but with typings */ /** Shorthand for `Vencord.Settings.plugins.PluginName`, but with typings */
store: SettingsStore<Def> & PrivateSettings; store: SettingsStore<Def> & PrivateSettings;
/** Shorthand for `Vencord.PlainSettings.plugins.PluginName`, but with typings */
plain: SettingsStore<Def> & PrivateSettings;
/** /**
* React hook for getting the settings for this plugin * React hook for getting the settings for this plugin
* @param filter optional filter to avoid rerenders for irrelevent settings * @param filter optional filter to avoid rerenders for irrelevent settings