ulysia/Vencord
1
0
Fork 0
Code Pull requests Activity

security: remove openPath, restrict openExternal

Browse source 
Now only allows opening http urls.
This commit is contained in:
Vendicated 2022-10-03 19:17:54 +02:00
parent 71a59f4020
commit 8fe60971f5
No known key found for this signature in database
GPG key ID: EC781ADFB93EFFA3
3 changed files with 15 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/components/Settings.tsx
View file

@ -88,7 +88,7 @@ export default ErrorBoundary.wrap(function Settings() {
Launch Directory Launch Directory
</Button> </Button>
<Button <Button
onClick={() => VencordNative.ipc.invoke(IpcEvents.OPEN_PATH, settingsDir, "quickCss.css")} onClick={() => VencordNative.ipc.invoke(IpcEvents.OPEN_QUICKCSS)}
size={Button.Sizes.SMALL} size={Button.Sizes.SMALL}
disabled={settingsDir === "Loading..."} disabled={settingsDir === "Loading..."}
> >

15
src/ipcMain/index.ts
View file

@ -29,8 +29,19 @@ function readSettings() {
// Fix for screensharing in Electron >= 17 // Fix for screensharing in Electron >= 17
ipcMain.handle(IpcEvents.GET_DESKTOP_CAPTURE_SOURCES, (_, opts) => desktopCapturer.getSources(opts)); ipcMain.handle(IpcEvents.GET_DESKTOP_CAPTURE_SOURCES, (_, opts) => desktopCapturer.getSources(opts));
ipcMain.handle(IpcEvents.OPEN_PATH, (_, ...pathElements) => shell.openPath(join(...pathElements))); ipcMain.handle(IpcEvents.OPEN_QUICKCSS, () => shell.openPath(QUICKCSS_PATH));
ipcMain.handle(IpcEvents.OPEN_EXTERNAL, (_, url) => shell.openExternal(url));
ipcMain.handle(IpcEvents.OPEN_EXTERNAL, (_, url) => {
try {
var { protocol } = new URL(url);
} catch {
throw "Malformed URL";
}
if (protocol !== "https:" && protocol !== "http:")
throw "Disallowed protocol.";
shell.openExternal(url);
});
ipcMain.handle(IpcEvents.GET_QUICK_CSS, () => readCss()); ipcMain.handle(IpcEvents.GET_QUICK_CSS, () => readCss());

2
src/utils/IpcEvents.ts
View file

@ -18,7 +18,7 @@ export default strEnum({
GET_SETTINGS: "VencordGetSettings", GET_SETTINGS: "VencordGetSettings",
SET_SETTINGS: "VencordSetSettings", SET_SETTINGS: "VencordSetSettings",
OPEN_EXTERNAL: "VencordOpenExternal", OPEN_EXTERNAL: "VencordOpenExternal",
OPEN_PATH: "VencordOpenPath", OPEN_QUICKCSS: "VencordOpenQuickCss",
GET_UPDATES: "VencordGetUpdates", GET_UPDATES: "VencordGetUpdates",
GET_REPO: "VencordGetRepo", GET_REPO: "VencordGetRepo",
GET_HASHES: "VencordGetHashes", GET_HASHES: "VencordGetHashes",