Make typescript happy, tsc test run in CI

.github/workflows/lint.yml

@@ -24,4 +24,4 @@ jobs:
               run: pnpm install --frozen-lockfile
 
             - name: Lint & Test if it compiles
-              run: pnpm lint && pnpm build
+              run: pnpm test

package.json

@@ -1,28 +1,30 @@
 {
-    "devDependencies": {
+  "scripts": {
-        "@types/node": "^18.7.13",
+    "build": "node build.mjs",
-        "@types/react": "^18.0.17",
+    "buildWeb": "node buildWeb.mjs",
-        "@types/yazl": "^2.4.2",
+    "inject": "node scripts/patcher/install.js",
-        "@typescript-eslint/parser": "^5.39.0",
+    "lint": "eslint . --ext .js,.jsx,.ts,.tsx",
-        "electron": "^20.1.0",
+    "lint:fix": "pnpm lint --fix",
-        "esbuild": "^0.15.5",
+    "test": "pnpm lint && pnpm build && pnpm testTsc",
-        "eslint": "^8.24.0",
+    "testTsc": "tsc --noEmit",
-        "typescript": "^4.8.4",
+    "uninject": "node scripts/patcher/uninstall.js",
-        "yazl": "^2.5.1"
+    "watch": "node build.mjs --watch"
-    },
+  },
-    "dependencies": {
+  "dependencies": {
-        "console-menu": "^0.1.0",
+    "console-menu": "^0.1.0",
-        "discord-types": "^1.3.26",
+    "electron-devtools-installer": "^3.2.0"
-        "electron-devtools-installer": "^3.2.0"
+  },
-    },
+  "devDependencies": {
-    "scripts": {
+    "@types/node": "^18.7.13",
-        "buildWeb": "node buildWeb.mjs",
+    "@types/react": "^18.0.17",
-        "build": "node build.mjs",
+    "@types/yazl": "^2.4.2",
-        "watch": "node build.mjs --watch",
+    "@typescript-eslint/parser": "^5.39.0",
-        "inject": "node scripts/patcher/install.js",
+    "discord-types": "^1.3.26",
-        "uninject": "node scripts/patcher/uninstall.js",
+    "electron": "^20.1.0",
-        "lint": "eslint . --ext .js,.jsx,.ts,.tsx",
+    "esbuild": "^0.15.5",
-        "lint:fix": "pnpm lint --fix"
+    "eslint": "^8.24.0",
-    },
+    "typescript": "^4.8.4",
-    "packageManager": "pnpm@7.12.2"
+    "yazl": "^2.5.1"
+  },
+  "packageManager": "pnpm@7.12.2"
 }

src/Vencord.ts

@@ -22,7 +22,7 @@ Object.defineProperty(window, "IS_WEB", {
     enumerable: true
 });
 
-export let Components;
+export let Components: any;
 
 async function init() {
     await onceReady;

src/api/MessageEvents.ts

@@ -67,7 +67,7 @@ type ClickListener = (message: Message, channel: Channel, event: MouseEvent) =>
 
 const listeners = new Set<ClickListener>();
 
-export function _handleClick(message, channel, event) {
+export function _handleClick(message: Message, channel: Channel, event: MouseEvent) {
     for (const listener of listeners) {
         try {
             listener(message, channel, event);

src/components/Settings.tsx

@@ -127,7 +127,7 @@ export default ErrorBoundary.wrap(function Settings() {
                         disabled={p.required || dependency}
                         key={p.name}
                         value={settings.plugins[p.name].enabled || p.required || dependency}
-                        onChange={v => {
+                        onChange={(v: boolean) => {
                             settings.plugins[p.name].enabled = v;
                             let needsRestart = Boolean(p.patches?.length);
                             if (v) {

src/globals.d.ts

@@ -12,7 +12,7 @@ declare global {
             push(chunk: any): any;
             pop(): any;
         };
-        [k: PropertyKey]: any;
+        [k: string]: any;
     }
 }
 

src/plugins/randomiseFileNames.ts

@@ -16,7 +16,7 @@ export default definePlugin({
         },
     ],
 
-    rand(file) {
+    rand(file: string) {
         const chars =
             "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789";
         const rand = Array.from(

src/utils/ChangeList.ts

@@ -1,5 +1,5 @@
 export class ChangeList<T>{
-    private set = new Set<T>;
+    private set = new Set<T>();
 
     public get changeCount() {
         return this.set.size;

src/utils/misc.tsx

@@ -28,7 +28,7 @@ export function lazyWebpack<T = any>(filter: FilterFn): T {
         construct: (_, args, newTarget) => Reflect.construct(getMod(), args, newTarget),
         deleteProperty: (_, prop) => delete getMod()[prop],
         defineProperty: (_, property, attributes) => !!Object.defineProperty(getMod(), property, attributes)
-    }) as T;
+    }) as any as T;
 }
 
 /**

src/utils/quickCss.ts

@@ -12,7 +12,8 @@ export async function toggle(isEnabled: boolean) {
             VencordNative.ipc.on(IpcEvents.QUICK_CSS_UPDATE, (_, css: string) => style.innerText = css);
             style.innerText = await VencordNative.ipc.invoke(IpcEvents.GET_QUICK_CSS);
         }
-    } else style.disabled = !isEnabled;
+    } else // @ts-ignore yes typescript, property 'disabled' does exist on type 'HTMLStyleElement' u should try reading the docs some time
+        style.disabled = !isEnabled;
 }
 
 document.addEventListener("DOMContentLoaded", () => {

tsconfig.json

@@ -2,7 +2,13 @@
     "compilerOptions": {
         "allowSyntheticDefaultImports": true,
         "esModuleInterop": true,
-        "lib": ["DOM", "esnext", "esnext.array", "esnext.asynciterable", "esnext.symbol"],
+        "lib": [
+            "DOM",
+            "esnext",
+            "esnext.array",
+            "esnext.asynciterable",
+            "esnext.symbol"
+        ],
         "module": "commonjs",
         "moduleResolution": "node",
         "strict": true,