Refactored enums

src/Api/Jobs/UserJobs/EditUserAccessRankJob.php

@@ -25,7 +25,7 @@ class EditUserAccessRankJob extends AbstractJob
 		Logger::log('{user} changed {subject}\'s access rank to {rank}', [
 			'user' => TextHelper::reprUser(Auth::getCurrentUser()),
 			'subject' => TextHelper::reprUser($user),
-			'rank' => $newAccessRank->toString()]);
+			'rank' => $newAccessRank->toDisplayString()]);
 
 		return $user;
 	}

src/Enums/AbstractEnum.php

@@ -1,19 +1,12 @@
 <?php
-abstract class Enum
+abstract class AbstractEnum implements IEnum
 {
 	public abstract function toString();
 
-	public function _toString($constant)
-	{
-		$cls = new ReflectionClass(get_called_class());
-		$constants = $cls->getConstants();
-		return array_search($constant, $constants);
-	}
-
 	public function toDisplayString()
 	{
 		return TextCaseConverter::convert($this->toString(),
-			TextCaseConverter::CAMEL_CASE,
+			TextCaseConverter::SPINAL_CASE,
 			TextCaseConverter::BLANK_CASE);
 	}
 

src/Enums/AccessRank.php

@@ -1,5 +1,5 @@
 <?php
-class AccessRank extends Enum implements IValidatable
+class AccessRank extends AbstractEnum implements IEnum, IValidatable
 {
 	const Anonymous = 0;
 	const Registered = 1;
@@ -22,7 +22,16 @@ class AccessRank extends Enum implements IValidatable
 
 	public function toString()
 	{
-		return self::_toString($this->accessRank);
+		switch ($this->accessRank)
+		{
+			case self::Anonymous: return 'anonymous';
+			case self::Registered: return 'registered';
+			case self::PowerUser: return 'power-user';
+			case self::Moderator: return 'moderator';
+			case self::Admin: return 'admin';
+			case self::Nobody: return 'nobody';
+		}
+		return null;
 	}
 
 	public static function getAll()

src/Enums/IEnum.php

@@ -0,0 +1,6 @@
+<?php
+interface IEnum
+{
+	public function toString();
+	public function toDisplayString();
+}

src/Enums/PostSafety.php

@@ -1,5 +1,5 @@
 <?php
-class PostSafety extends Enum implements IValidatable
+class PostSafety extends AbstractEnum implements IEnum, IValidatable
 {
 	const Safe = 1;
 	const Sketchy = 2;

src/Enums/PostType.php

@@ -1,5 +1,5 @@
 <?php
-class PostType extends Enum implements IValidatable
+class PostType extends AbstractEnum implements IEnum, IValidatable
 {
 	const Image = 1;
 	const Flash = 2;
@@ -20,7 +20,14 @@ class PostType extends Enum implements IValidatable
 
 	public function toString()
 	{
-		return self::_toString($this->type);
+		switch ($this->type)
+		{
+			case self::Image: return 'image';
+			case self::Flash: return 'flash';
+			case self::Youtube: return 'youtube';
+			case self::Video: return 'video';
+		}
+		return null;
 	}
 
 	public function validate()

src/Enums/Privilege.php

@@ -1,5 +1,5 @@
 <?php
-class Privilege extends Enum
+class Privilege extends AbstractEnum implements IEnum
 {
 	const ListPosts = 'listPosts';
 	const ViewPost = 'viewPost';
@@ -71,4 +71,9 @@ class Privilege extends Enum
 			$string .= '.' . $this->secondary;
 		return $string;
 	}
+
+	public function toDisplayString()
+	{
+		return $this->toString();
+	}
 }