From 5159214e804b141c84e33c7236f66bd43d8dc93b Mon Sep 17 00:00:00 2001
From: Marcin Kurczewski <mkurczew@gmail.com>
Date: Sat, 27 Sep 2014 10:59:37 +0200
Subject: [PATCH] Added searching by tags and ids

---
 TODO                                          |  7 +--
 .../js/Presenters/PostListPresenter.js        |  2 +-
 public_html/templates/post.tpl                |  2 +-
 src/Dao/AbstractDao.php                       | 55 +++++++++++++++++--
 src/Dao/PostDao.php                           | 20 +++++++
 src/SearchServices/Filters/BasicFilter.php    |  2 +-
 src/SearchServices/Filters/IFilter.php        |  2 +-
 src/SearchServices/Filters/PostFilter.php     |  2 +
 .../Parsers/AbstractSearchParser.php          | 34 ++++++++++--
 .../Parsers/PostSearchParser.php              | 21 ++++++-
 .../Parsers/SnapshotSearchParser.php          |  4 +-
 .../Requirements/IRequirementValue.php        |  6 ++
 .../{ => Requirements}/Requirement.php        |  4 +-
 .../RequirementCompositeValue.php             | 16 ++++++
 .../Requirements/RequirementRangedValue.php   | 28 ++++++++++
 .../Requirements/RequirementSingleValue.php   | 22 ++++++++
 .../{ => Tokens}/NamedSearchToken.php         |  2 +-
 .../{ => Tokens}/SearchToken.php              |  2 +-
 src/Services/PostService.php                  |  8 +--
 19 files changed, 206 insertions(+), 33 deletions(-)
 create mode 100644 src/SearchServices/Requirements/IRequirementValue.php
 rename src/SearchServices/{ => Requirements}/Requirement.php (80%)
 create mode 100644 src/SearchServices/Requirements/RequirementCompositeValue.php
 create mode 100644 src/SearchServices/Requirements/RequirementRangedValue.php
 create mode 100644 src/SearchServices/Requirements/RequirementSingleValue.php
 rename src/SearchServices/{ => Tokens}/NamedSearchToken.php (81%)
 rename src/SearchServices/{ => Tokens}/SearchToken.php (88%)

diff --git a/TODO b/TODO
index e4f671bb..6968cd9a 100644
--- a/TODO
+++ b/TODO
@@ -26,10 +26,10 @@ everything related to posts:
         - score
         - comment count
         - regard safety settings
+        - regard disliked settings
+        - add search form (query, order and safety) to post list presenter
         - add warning if no posts were found
         - search filters
-            - tag
-            - -tag
             - submit:rr-
             - comment:rr-
             - comment: 3..5
@@ -42,7 +42,6 @@ everything related to posts:
             - date:yyyy[-mm[-dd]]..yyyy[-mm[-dd]]
             - filesize:3K..5M
             - imgsize:huge/large/medium/small
-            - id:3,4,5
             - hash:postName
             - type:img/flash/yt/video
             - special:liked
@@ -60,8 +59,6 @@ everything related to posts:
             - order:favdate
             - order:filesize
             - order:random (at least unstable version)
-        - safe/sketchy/unsafe buttons and top navigation search goes to post
-          list presenter
 
 everything related to users:
     - banning
diff --git a/public_html/js/Presenters/PostListPresenter.js b/public_html/js/Presenters/PostListPresenter.js
index 800d7adf..90282f5f 100644
--- a/public_html/js/Presenters/PostListPresenter.js
+++ b/public_html/js/Presenters/PostListPresenter.js
@@ -54,7 +54,7 @@ App.Presenters.PostListPresenter = function(
 		loaded();
 
 		var searchArgs = util.parseComplexRouteArgs(args.searchArgs);
-		pagedCollectionPresenter.reinit({page: searchArgs.page, searchParams: {order: searchArgs.order}});
+		pagedCollectionPresenter.reinit({page: searchArgs.page, searchParams: {query: searchArgs.query, order: searchArgs.order}});
 	}
 
 	function render() {
diff --git a/public_html/templates/post.tpl b/public_html/templates/post.tpl
index b82b218a..1bb3156c 100644
--- a/public_html/templates/post.tpl
+++ b/public_html/templates/post.tpl
@@ -16,7 +16,7 @@
 		<ul class="tags">
 			<% _.each(post.tags, function(tag) { %>
 				<li>
-					<a href="#/posts/search=<%= tag.name %>">
+					<a href="#/posts/query=<%= tag.name %>">
 						<%= tag.name %>
 						<span class="usages"><%= (tag.usages) %></span>
 					</a>
diff --git a/src/Dao/AbstractDao.php b/src/Dao/AbstractDao.php
index f863b1e3..bf583281 100644
--- a/src/Dao/AbstractDao.php
+++ b/src/Dao/AbstractDao.php
@@ -65,7 +65,7 @@ abstract class AbstractDao implements ICrudDao
 
 	public function findFiltered(\Szurubooru\SearchServices\Filters\IFilter $searchFilter)
 	{
-		$query = $this->fpdo->from($this->tableName);
+		$query = $this->fpdo->from($this->tableName)->disableSmartJoin();
 
 		$orderByString = self::compileOrderBy($searchFilter->getOrder());
 		if ($orderByString)
@@ -79,7 +79,7 @@ abstract class AbstractDao implements ICrudDao
 		}
 		$entities = $this->arrayToEntities(iterator_to_array($query));
 
-		$query = $this->fpdo->from($this->tableName);
+		$query = $this->fpdo->from($this->tableName)->disableSmartJoin();
 		$this->decorateQueryFromFilter($query, $searchFilter);
 		$totalRecords = count($query);
 
@@ -172,6 +172,52 @@ abstract class AbstractDao implements ICrudDao
 	{
 	}
 
+	protected function decorateQueryFromRequirement($query, \Szurubooru\SearchServices\Requirements\Requirement $requirement)
+	{
+		$value = $requirement->getValue();
+		$sqlColumn = $requirement->getType();
+
+		if ($value instanceof \Szurubooru\SearchServices\Requirements\RequirementCompositeValue)
+		{
+			$sql = $sqlColumn;
+			$bindings = [$value->getValues()];
+		}
+
+		else if ($value instanceof \Szurubooru\SearchServices\Requirements\RequirementRangedValue)
+		{
+			if ($value->getMinValue() and $value->getMaxValue())
+			{
+				$sql = $sqlColumn . ' >= ? AND ' . $sqlColumn . ' <= ?';
+				$bindings = [$value->getMinValue(), $value->getMaxValue()];
+			}
+			elseif ($value->getMinValue())
+			{
+				$sql = $sqlColumn . ' >= ?';
+				$bindings = [$value->getMinValue()];
+			}
+			elseif ($value->getMaxValue())
+			{
+				$sql = $sqlColumn . ' <= ?';
+				$bindings = [$value->getMaxValue()];
+			}
+			else
+				throw new \RuntimeException('Neither min or max value was supplied');
+		}
+
+		else if ($value instanceof \Szurubooru\SearchServices\Requirements\RequirementSingleValue)
+		{
+			$sql = $sqlColumn;
+			$bindings = [$value->getValue()];
+		}
+
+		else
+			throw new \Exception('Bad value: ' . get_class($value));
+
+		if ($requirement->isNegated())
+			$sql = 'NOT (' . $sql . ')';
+		call_user_func_array([$query, 'where'], array_merge([$sql], $bindings));
+	}
+
 	protected function arrayToEntities(array $arrayEntities)
 	{
 		$entities = [];
@@ -193,10 +239,7 @@ abstract class AbstractDao implements ICrudDao
 	{
 		foreach ($filter->getRequirements() as $requirement)
 		{
-			if ($requirement->isNegated())
-				$query->where('NOT ' . $requirement->getType(), $requirement->getValue());
-			else
-				$query->where($requirement->getType(), $requirement->getValue());
+			$this->decorateQueryFromRequirement($query, $requirement);
 		}
 	}
 
diff --git a/src/Dao/PostDao.php b/src/Dao/PostDao.php
index 32e6f174..2aee3f49 100644
--- a/src/Dao/PostDao.php
+++ b/src/Dao/PostDao.php
@@ -93,6 +93,26 @@ class PostDao extends AbstractDao implements ICrudDao
 		$this->syncPostRelations($post);
 	}
 
+	protected function decorateQueryFromRequirement($query, \Szurubooru\SearchServices\Requirements\Requirement $requirement)
+	{
+		if ($requirement->getType() === \Szurubooru\SearchServices\Filters\PostFilter::REQUIREMENT_TAG)
+		{
+			$sql = 'EXISTS (
+				SELECT 1 FROM postTags
+				INNER JOIN tags ON postTags.tagId = tags.id
+				WHERE postTags.postId = posts.id
+					AND LOWER(tags.name) = LOWER(?))';
+
+			if ($requirement->isNegated())
+				$sql = 'NOT ' . $sql;
+
+			$query->where($sql, $requirement->getValue()->getValue());
+			return;
+		}
+
+		parent::decorateQueryFromRequirement($query, $requirement);
+	}
+
 	private function getTags(\Szurubooru\Entities\Post $post)
 	{
 		return $this->tagDao->findByPostId($post->getId());
diff --git a/src/SearchServices/Filters/BasicFilter.php b/src/SearchServices/Filters/BasicFilter.php
index 7b4ec432..e8458095 100644
--- a/src/SearchServices/Filters/BasicFilter.php
+++ b/src/SearchServices/Filters/BasicFilter.php
@@ -23,7 +23,7 @@ class BasicFilter implements IFilter
 		$this->order = $order;
 	}
 
-	public function addRequirement(\Szurubooru\SearchServices\Requirement $requirement)
+	public function addRequirement(\Szurubooru\SearchServices\Requirements\Requirement $requirement)
 	{
 		$this->requirements[] = $requirement;
 	}
diff --git a/src/SearchServices/Filters/IFilter.php b/src/SearchServices/Filters/IFilter.php
index a8eccb8c..93709119 100644
--- a/src/SearchServices/Filters/IFilter.php
+++ b/src/SearchServices/Filters/IFilter.php
@@ -12,7 +12,7 @@ interface IFilter
 
 	public function getRequirements();
 
-	public function addRequirement(\Szurubooru\SearchServices\Requirement $requirement);
+	public function addRequirement(\Szurubooru\SearchServices\Requirements\Requirement $requirement);
 
 	public function getPageSize();
 
diff --git a/src/SearchServices/Filters/PostFilter.php b/src/SearchServices/Filters/PostFilter.php
index d572310d..38794fd8 100644
--- a/src/SearchServices/Filters/PostFilter.php
+++ b/src/SearchServices/Filters/PostFilter.php
@@ -3,4 +3,6 @@ namespace Szurubooru\SearchServices\Filters;
 
 class PostFilter extends BasicFilter implements IFilter
 {
+	const REQUIREMENT_TAG = 'tag';
+	const REQUIREMENT_ID = 'id';
 }
diff --git a/src/SearchServices/Parsers/AbstractSearchParser.php b/src/SearchServices/Parsers/AbstractSearchParser.php
index 2a7c1e2c..a2a5fea9 100644
--- a/src/SearchServices/Parsers/AbstractSearchParser.php
+++ b/src/SearchServices/Parsers/AbstractSearchParser.php
@@ -3,6 +3,9 @@ namespace Szurubooru\SearchServices\Parsers;
 
 abstract class AbstractSearchParser
 {
+	const ALLOW_COMPOSITE = 1;
+	const ALLOW_RANGES = 2;
+
 	public function createFilterFromInputReader(\Szurubooru\Helpers\InputReader $inputReader)
 	{
 		$filter = $this->createFilter();
@@ -18,9 +21,9 @@ abstract class AbstractSearchParser
 
 		foreach ($tokens as $token)
 		{
-			if ($token instanceof \Szurubooru\SearchServices\NamedSearchToken)
+			if ($token instanceof \Szurubooru\SearchServices\Tokens\NamedSearchToken)
 				$this->decorateFilterFromNamedToken($filter, $token);
-			elseif ($token instanceof \Szurubooru\SearchServices\SearchToken)
+			elseif ($token instanceof \Szurubooru\SearchServices\Tokens\SearchToken)
 				$this->decorateFilterFromToken($filter, $token);
 			else
 				throw new \RuntimeException('Invalid search token type: ' . get_class($token));
@@ -37,6 +40,27 @@ abstract class AbstractSearchParser
 
 	protected abstract function getOrderColumn($token);
 
+	protected function createRequirementValue($text, $flags = 0)
+	{
+		if ((($flags & self::ALLOW_RANGES) === self::ALLOW_RANGES) and substr_count($text, '..') === 1)
+		{
+			list ($minValue, $maxValue) = explode('..', $text);
+			$tokenValue = new \Szurubooru\SearchServices\Requirements\RequirementRangedValue();
+			$tokenValue->setMinValue($minValue);
+			$tokenValue->setMaxValue($maxValue);
+			return $tokenValue;
+		}
+		else if ((($flags & self::ALLOW_COMPOSITE) === self::ALLOW_COMPOSITE) and strpos($text, ',') !== false)
+		{
+			$values = explode(',', $text);
+			$tokenValue = new \Szurubooru\SearchServices\Requirements\RequirementCompositeValue();
+			$tokenValue->setValues($values);
+			return $tokenValue;
+		}
+
+		return new \Szurubooru\SearchServices\Requirements\RequirementSingleValue($text);
+	}
+
 	private function getOrder($query)
 	{
 		$order = [];
@@ -75,14 +99,14 @@ abstract class AbstractSearchParser
 
 			if (strpos($tokenText, ':') !== false)
 			{
-				$searchToken = new \Szurubooru\SearchServices\NamedSearchToken();
-				list ($tokenKey, $tokenValue) = explode(':', $tokenText, 1);
+				$searchToken = new \Szurubooru\SearchServices\Tokens\NamedSearchToken();
+				list ($tokenKey, $tokenValue) = explode(':', $tokenText, 2);
 				$searchToken->setKey($tokenKey);
 				$searchToken->setValue($tokenValue);
 			}
 			else
 			{
-				$searchToken = new \Szurubooru\SearchServices\SearchToken();
+				$searchToken = new \Szurubooru\SearchServices\Tokens\SearchToken();
 				$searchToken->setValue($tokenText);
 			}
 
diff --git a/src/SearchServices/Parsers/PostSearchParser.php b/src/SearchServices/Parsers/PostSearchParser.php
index 23dc6a22..02b4f957 100644
--- a/src/SearchServices/Parsers/PostSearchParser.php
+++ b/src/SearchServices/Parsers/PostSearchParser.php
@@ -10,12 +10,27 @@ class PostSearchParser extends AbstractSearchParser
 
 	protected function decorateFilterFromToken($filter, $token)
 	{
-		throw new \BadMethodCallException('Not supported');
+		$requirement = new \Szurubooru\SearchServices\Requirements\Requirement();
+		$requirement->setType(\Szurubooru\SearchServices\Filters\PostFilter::REQUIREMENT_TAG);
+		$requirement->setValue($this->createRequirementValue($token->getValue()));
+		$requirement->setNegated($token->isNegated());
+		$filter->addRequirement($requirement);
 	}
 
-	protected function decorateFilterFromNamedToken($filter, $namedToken)
+	protected function decorateFilterFromNamedToken($filter, $token)
 	{
-		throw new \BadMethodCallException('Not supported');
+		if ($token->getKey() === 'id')
+		{
+			$requirement = new \Szurubooru\SearchServices\Requirements\Requirement();
+			$requirement->setType(\Szurubooru\SearchServices\Filters\PostFilter::REQUIREMENT_ID);
+			$requirement->setValue($this->createRequirementValue($token->getValue(), self::ALLOW_COMPOSITE | self::ALLOW_RANGES));
+			$requirement->setNegated($token->isNegated());
+			$filter->addRequirement($requirement);
+		}
+		else
+		{
+			throw new \BadMethodCallException('Not supported');
+		}
 	}
 
 	protected function getOrderColumn($token)
diff --git a/src/SearchServices/Parsers/SnapshotSearchParser.php b/src/SearchServices/Parsers/SnapshotSearchParser.php
index 3c268c41..a51c7a7e 100644
--- a/src/SearchServices/Parsers/SnapshotSearchParser.php
+++ b/src/SearchServices/Parsers/SnapshotSearchParser.php
@@ -20,12 +20,12 @@ class SnapshotSearchParser extends AbstractSearchParser
 
 		$requirement = new \Szurubooru\SearchServices\Requirements\Requirement();
 		$requirement->setType(\Szurubooru\SearchServices\Filters\SnapshotFilter::REQUIREMENT_PRIMARY_KEY);
-		$requirement->setValue($primaryKey);
+		$requirement->setValue($this->createRequirementValue($primaryKey));
 		$filter->addRequirement($requirement);
 
 		$requirement = new \Szurubooru\SearchServices\Requirements\Requirement();
 		$requirement->setType(\Szurubooru\SearchServices\Filters\SnapshotFilter::REQUIREMENT_TYPE);
-		$requirement->setValue(\Szurubooru\Helpers\EnumHelper::snapshotTypeFromString($type));
+		$requirement->setValue($this->createRequirementValue(\Szurubooru\Helpers\EnumHelper::snapshotTypeFromString($type)));
 		$filter->addRequirement($requirement);
 	}
 
diff --git a/src/SearchServices/Requirements/IRequirementValue.php b/src/SearchServices/Requirements/IRequirementValue.php
new file mode 100644
index 00000000..884c0e7b
--- /dev/null
+++ b/src/SearchServices/Requirements/IRequirementValue.php
@@ -0,0 +1,6 @@
+<?php
+namespace Szurubooru\SearchServices\Requirements;
+
+interface IRequirementValue
+{
+}
diff --git a/src/SearchServices/Requirement.php b/src/SearchServices/Requirements/Requirement.php
similarity index 80%
rename from src/SearchServices/Requirement.php
rename to src/SearchServices/Requirements/Requirement.php
index 4254a1f7..e7ee1e80 100644
--- a/src/SearchServices/Requirement.php
+++ b/src/SearchServices/Requirements/Requirement.php
@@ -1,5 +1,5 @@
 <?php
-namespace Szurubooru\SearchServices;
+namespace Szurubooru\SearchServices\Requirements;
 
 class Requirement
 {
@@ -32,7 +32,7 @@ class Requirement
 		return $this->value;
 	}
 
-	public function setValue($value)
+	public function setValue(IRequirementValue $value)
 	{
 		$this->value = $value;
 	}
diff --git a/src/SearchServices/Requirements/RequirementCompositeValue.php b/src/SearchServices/Requirements/RequirementCompositeValue.php
new file mode 100644
index 00000000..c18a3215
--- /dev/null
+++ b/src/SearchServices/Requirements/RequirementCompositeValue.php
@@ -0,0 +1,16 @@
+<?php
+namespace Szurubooru\SearchServices\Requirements;
+
+class RequirementCompositeValue implements IRequirementValue
+{
+	private $values = [];
+	public function getValues()
+	{
+		return $this->values;
+	}
+
+	public function setValues(array $values)
+	{
+		$this->values = $values;
+	}
+}
diff --git a/src/SearchServices/Requirements/RequirementRangedValue.php b/src/SearchServices/Requirements/RequirementRangedValue.php
new file mode 100644
index 00000000..dd543d34
--- /dev/null
+++ b/src/SearchServices/Requirements/RequirementRangedValue.php
@@ -0,0 +1,28 @@
+<?php
+namespace Szurubooru\SearchServices\Requirements;
+
+class RequirementRangedValue implements IRequirementValue
+{
+	private $minValue = null;
+	private $maxValue = null;
+
+	public function getMinValue()
+	{
+		return $this->minValue;
+	}
+
+	public function setMinValue($minValue)
+	{
+		$this->minValue = $minValue;
+	}
+
+	public function getMaxValue()
+	{
+		return $this->maxValue;
+	}
+
+	public function setMaxValue($maxValue)
+	{
+		$this->maxValue = $maxValue;
+	}
+}
diff --git a/src/SearchServices/Requirements/RequirementSingleValue.php b/src/SearchServices/Requirements/RequirementSingleValue.php
new file mode 100644
index 00000000..65215916
--- /dev/null
+++ b/src/SearchServices/Requirements/RequirementSingleValue.php
@@ -0,0 +1,22 @@
+<?php
+namespace Szurubooru\SearchServices\Requirements;
+
+class RequirementSingleValue implements IRequirementValue
+{
+	private $value;
+
+	public function __construct($value)
+	{
+		$this->setValue($value);
+	}
+
+	public function getValue()
+	{
+		return $this->value;
+	}
+
+	public function setValue($value)
+	{
+		$this->value = $value;
+	}
+}
diff --git a/src/SearchServices/NamedSearchToken.php b/src/SearchServices/Tokens/NamedSearchToken.php
similarity index 81%
rename from src/SearchServices/NamedSearchToken.php
rename to src/SearchServices/Tokens/NamedSearchToken.php
index d31e3323..f13b21a3 100644
--- a/src/SearchServices/NamedSearchToken.php
+++ b/src/SearchServices/Tokens/NamedSearchToken.php
@@ -1,5 +1,5 @@
 <?php
-namespace Szurubooru\SearchServices;
+namespace Szurubooru\SearchServices\Tokens;
 
 class NamedSearchToken extends SearchToken
 {
diff --git a/src/SearchServices/SearchToken.php b/src/SearchServices/Tokens/SearchToken.php
similarity index 88%
rename from src/SearchServices/SearchToken.php
rename to src/SearchServices/Tokens/SearchToken.php
index 8caabf88..6c616545 100644
--- a/src/SearchServices/SearchToken.php
+++ b/src/SearchServices/Tokens/SearchToken.php
@@ -1,5 +1,5 @@
 <?php
-namespace Szurubooru\SearchServices;
+namespace Szurubooru\SearchServices\Tokens;
 
 class SearchToken
 {
diff --git a/src/Services/PostService.php b/src/Services/PostService.php
index c399009d..cb119054 100644
--- a/src/Services/PostService.php
+++ b/src/Services/PostService.php
@@ -91,14 +91,14 @@ class PostService
 		{
 			$filter = new \Szurubooru\SearchServices\Filters\SnapshotFilter();
 
-			$requirement = new \Szurubooru\SearchServices\Requirement();
+			$requirement = new \Szurubooru\SearchServices\Requirements\Requirement();
 			$requirement->setType(\Szurubooru\SearchServices\Filters\SnapshotFilter::REQUIREMENT_PRIMARY_KEY);
-			$requirement->setValue($post->getId());
+			$requirement->setValue(new \Szurubooru\SearchServices\Requirements\RequirementSingleValue($post->getId()));
 			$filter->addRequirement($requirement);
 
-			$requirement = new \Szurubooru\SearchServices\Requirement();
+			$requirement = new \Szurubooru\SearchServices\Requirements\Requirement();
 			$requirement->setType(\Szurubooru\SearchServices\Filters\SnapshotFilter::REQUIREMENT_TYPE);
-			$requirement->setValue(\Szurubooru\Entities\Snapshot::TYPE_POST);
+			$requirement->setValue(new \Szurubooru\SearchServices\Requirements\RequirementSingleValue(\Szurubooru\Entities\Snapshot::TYPE_POST));
 			$filter->addRequirement($requirement);
 
 			return $this->historyService->getFiltered($filter)->getEntities();