From 538165e3ff7b7b3f27ae9654ed95bd2b78f8c7a0 Mon Sep 17 00:00:00 2001
From: Marcin Kurczewski <mkurczew@gmail.com>
Date: Tue, 10 Jun 2014 10:47:05 +0200
Subject: [PATCH] Moved job context management to interface

---
 src/Api/Jobs/AbstractJob.php              | 4 ----
 src/Api/Jobs/IJob.php                     | 7 +++++++
 src/Api/Jobs/PostJobs/AddPostJob.php      | 2 +-
 tests/Tests/ApiTests/ApiPrivilegeTest.php | 4 ++--
 4 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/src/Api/Jobs/AbstractJob.php b/src/Api/Jobs/AbstractJob.php
index bd2ebafb..1f65638b 100644
--- a/src/Api/Jobs/AbstractJob.php
+++ b/src/Api/Jobs/AbstractJob.php
@@ -1,10 +1,6 @@
 <?php
 abstract class AbstractJob implements IJob
 {
-	const CONTEXT_NORMAL = 1;
-	const CONTEXT_BATCH_EDIT = 2;
-	const CONTEXT_BATCH_ADD = 3;
-
 	protected $arguments = [];
 	protected $context = self::CONTEXT_NORMAL;
 	protected $subJobs;
diff --git a/src/Api/Jobs/IJob.php b/src/Api/Jobs/IJob.php
index 47c15ca2..24fd5002 100644
--- a/src/Api/Jobs/IJob.php
+++ b/src/Api/Jobs/IJob.php
@@ -1,9 +1,16 @@
 <?php
 interface IJob
 {
+	const CONTEXT_NORMAL = 1;
+	const CONTEXT_BATCH_EDIT = 2;
+	const CONTEXT_BATCH_ADD = 3;
+
 	public function prepare();
 	public function execute();
 
+	public function getContext();
+	public function setContext($context);
+
 	public function getRequiredArguments();
 	public function getRequiredMainPrivilege();
 	public function getRequiredSubPrivileges();
diff --git a/src/Api/Jobs/PostJobs/AddPostJob.php b/src/Api/Jobs/PostJobs/AddPostJob.php
index 1675ab8e..258eef4a 100644
--- a/src/Api/Jobs/PostJobs/AddPostJob.php
+++ b/src/Api/Jobs/PostJobs/AddPostJob.php
@@ -32,7 +32,7 @@ class AddPostJob extends AbstractJob
 		Logger::bufferChanges();
 		foreach ($this->getSubJobs() as $subJob)
 		{
-			$subJob->setContext(AbstractJob::CONTEXT_BATCH_ADD);
+			$subJob->setContext(self::CONTEXT_BATCH_ADD);
 			try
 			{
 				Api::run($subJob, $arguments);
diff --git a/tests/Tests/ApiTests/ApiPrivilegeTest.php b/tests/Tests/ApiTests/ApiPrivilegeTest.php
index 62097dfd..b58094b9 100644
--- a/tests/Tests/ApiTests/ApiPrivilegeTest.php
+++ b/tests/Tests/ApiTests/ApiPrivilegeTest.php
@@ -53,7 +53,7 @@ class ApiPrivilegeTest extends AbstractFullApiTest
 
 		$ctx = function($job)
 		{
-			$job->setContext(AbstractJob::CONTEXT_BATCH_ADD);
+			$job->setContext(IJob::CONTEXT_BATCH_ADD);
 			return $job;
 		};
 		$this->testDynamicPostPrivilege($ctx(new EditPostContentJob), Privilege::AddPostContent);
@@ -139,7 +139,7 @@ class ApiPrivilegeTest extends AbstractFullApiTest
 
 		$ctx = function($job)
 		{
-			$job->setContext(AbstractJob::CONTEXT_BATCH_ADD);
+			$job->setContext(IJob::CONTEXT_BATCH_ADD);
 			return $job;
 		};
 		$this->testDynamicUserPrivilege($ctx(new EditUserAccessRankJob()), Privilege::EditUserAccessRank);