ulysia/szurubooru
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Updated TODO

Browse source 
Turned out these were some really bad ideas:

 1) mapping mime to file types would need to be duplicated in frontend
    and backend
 2) even if frontend and backend could share mime type map somehow,
    frontend would have problems with including it - ajax and the like
 3) it either would be impossible to refer to user avatar by their owner
    user names in URLs, or dao layer would need to synchronize avatar
    content files when user changes his name
 4) presenters still need to decorate urls with /data/ and
    /data/thumbnails/100x100
 5) managing file extensions of thumbnails would be a real pain since it
    partially shares its path names with real content, but under
    different mime type

Generally it's best to leave it to Apache to transmit correct mime.
This commit is contained in:
Marcin Kurczewski 2014-09-20 21:12:48 +02:00
parent b01adce156
commit 5d0cc93c7f
1 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
TODO
View file

@ -123,10 +123,6 @@ refactors:
separate PostTagDao for this) separate PostTagDao for this)
- post view proxy should retrieve full tags and full user - post view proxy should retrieve full tags and full user
- centralize markdown prefix decorators - centralize markdown prefix decorators
- move getPostContentPath and getAvatarSourcePath to Entity, include it in
ViewProxy and make presenters use it instead of duplicating the code
- after implementing Post::getPostContentPath, make paths include file
extensions so that apache can guess mime types when it serves the files
- add enum validation in IValidatables (needs refactors of enums and - add enum validation in IValidatables (needs refactors of enums and
possible disposal of EnumHelper in favor of something more subtle) possible disposal of EnumHelper in favor of something more subtle)
- (idea) keep denormalized data in separate tables, i.e. tag usages in - (idea) keep denormalized data in separate tables, i.e. tag usages in
@ -156,6 +152,7 @@ miscellaneous:
- endless pager should include information about page number - endless pager should include information about page number
- add README and INSTALL - apache2 has good README: - add README and INSTALL - apache2 has good README:
http://svn.apache.org/repos/asf/httpd/httpd/trunk/README http://svn.apache.org/repos/asf/httpd/httpd/trunk/README
remember to mention mod_mime_magic
- add spinner to forms such as registration, user query, login, settings - add spinner to forms such as registration, user query, login, settings
etc. make sure the code isn't too duplicated. etc. make sure the code isn't too duplicated.