Changed logger so it avoids blank lines

src/Api/Jobs/LogJobs/GetLogJob.php

@@ -30,6 +30,7 @@ class GetLogJob extends AbstractJob implements IPagedJob
 
 		//load lines
 		$lines = file_get_contents($path);
+		$lines = trim($lines);
 		$lines = explode(PHP_EOL, str_replace(["\r", "\n"], PHP_EOL, $lines));
 		$lines = array_reverse($lines);
 

src/Logger.php

@@ -27,13 +27,19 @@ class Logger
 		if (empty(self::$buffer))
 			return;
 
+		$sep = file_exists(self::$path)
+			? PHP_EOL
+			: '';
 		$fh = fopen(self::$path, 'ab');
 		if (!$fh)
 			throw new SimpleException('Cannot write to log files');
 		if (flock($fh, LOCK_EX))
 		{
 			foreach (self::$buffer as $logEvent)
-				fwrite($fh, $logEvent->getFullText() . PHP_EOL);
+			{
+				fwrite($fh, $sep . $logEvent->getFullText());
+				$sep = PHP_EOL;
+			}
 			fflush($fh);
 			flock($fh, LOCK_UN);
 			fclose($fh);

tests/JobTests/AddPostJobTest.php

@@ -143,7 +143,7 @@ class AddPostJobTest extends AbstractTest
 
 		$logPath = Logger::getLogPath();
 		$x = file_get_contents($logPath);
-		$lines = array_filter(explode("\n", $x));
+		$lines = explode("\n", $x);
 		$this->assert->areEqual(1, count($lines));
 	}
 

tests/JobTests/AddUserJobTest.php

@@ -300,7 +300,7 @@ class AddUserJobTest extends AbstractTest
 
 		$logPath = Logger::getLogPath();
 		$x = file_get_contents($logPath);
-		$lines = array_filter(explode("\n", $x));
+		$lines = explode("\n", $x);
 		$this->assert->areEqual(2, count($lines));
 	}
 }

tests/JobTests/EditPostJobTest.php

@@ -54,7 +54,7 @@ class EditPostJobTest extends AbstractTest
 
 		$logPath = Logger::getLogPath();
 		$x = file_get_contents($logPath);
-		$lines = array_filter(explode("\n", $x));
+		$lines = explode("\n", $x);
 		$this->assert->areEqual(3, count($lines));
 	}
 }

tests/JobTests/EditUserJobTest.php

@@ -52,7 +52,7 @@ class EditUserJobTest extends AbstractTest
 
 		$logPath = Logger::getLogPath();
 		$x = file_get_contents($logPath);
-		$lines = array_filter(explode("\n", $x));
+		$lines = explode("\n", $x);
 		$this->assert->areEqual(2, count($lines));
 	}
 

tests/JobTests/FlagPostJobTest.php

@@ -17,7 +17,7 @@ class FlagPostJobTest extends AbstractTest
 
 		$logPath = Logger::getLogPath();
 		$logs = file_get_contents($logPath);
-		$logs = array_filter(explode("\n", $logs));
+		$logs = explode("\n", $logs);
 		$this->assert->areEqual(1, count($logs));
 		$this->assert->isTrue(strpos($logs[0], 'flagged @' . $post->getId() . ' for moderator attention') !== false);
 	}

tests/JobTests/FlagUserJobTest.php

@@ -17,7 +17,7 @@ class FlagUserJobTest extends AbstractTest
 
 		$logPath = Logger::getLogPath();
 		$logs = file_get_contents($logPath);
-		$logs = array_filter(explode("\n", $logs));
+		$logs = explode("\n", $logs);
 		$this->assert->areEqual(1, count($logs));
 		$this->assert->isTrue(strpos($logs[0], 'flagged +' . $user->getName() . ' for moderator attention') !== false);
 	}