Reduced boilerplate by using default privileges

src/Api/AbstractJob.php

@@ -21,9 +21,20 @@ abstract class AbstractJob
 
 	public abstract function execute();
 
-	public abstract function requiresAuthentication();
+	public function requiresAuthentication()
-	public abstract function requiresConfirmedEmail();
+	{
-	public abstract function requiresPrivilege();
+		return false;
+	}
+
+	public function requiresConfirmedEmail()
+	{
+		return false;
+	}
+
+	public function requiresPrivilege()
+	{
+		return false;
+	}
 
 	public function getArgument($key)
 	{

src/Api/Jobs/AddPostJob.php

@@ -58,11 +58,6 @@ class AddPostJob extends AbstractJob
 		return Privilege::UploadPost;
 	}
 
-	public function requiresAuthentication()
-	{
-		return false;
-	}
-
 	public function requiresConfirmedEmail()
 	{
 		return getConfig()->registration->needEmailForUploading;

src/Api/Jobs/EditPostContentJob.php

@@ -26,14 +26,4 @@ class EditPostContentJob extends AbstractPostJob
 			Access::getIdentity($this->post->getUploader())
 		];
 	}
-
-	public function requiresAuthentication()
-	{
-		return false;
-	}
-
-	public function requiresConfirmedEmail()
-	{
-		return false;
-	}
 }

src/Api/Jobs/EditPostJob.php

@@ -31,19 +31,4 @@ class EditPostJob extends AbstractPostJob
 
 		return $post;
 	}
-
-	public function requiresPrivilege()
-	{
-		return false;
-	}
-
-	public function requiresAuthentication()
-	{
-		return false;
-	}
-
-	public function requiresConfirmedEmail()
-	{
-		return false;
-	}
 }

src/Api/Jobs/EditPostRelationsJob.php

@@ -41,14 +41,4 @@ class EditPostRelationsJob extends AbstractPostJob
 			Access::getIdentity($this->post->getUploader())
 		];
 	}
-
-	public function requiresAuthentication()
-	{
-		return false;
-	}
-
-	public function requiresConfirmedEmail()
-	{
-		return false;
-	}
 }

src/Api/Jobs/EditPostSafetyJob.php

@@ -32,14 +32,4 @@ class EditPostSafetyJob extends AbstractPostJob
 			Access::getIdentity($this->post->getUploader())
 		];
 	}
-
-	public function requiresAuthentication()
-	{
-		return false;
-	}
-
-	public function requiresConfirmedEmail()
-	{
-		return false;
-	}
 }

src/Api/Jobs/EditPostSourceJob.php

@@ -32,14 +32,4 @@ class EditPostSourceJob extends AbstractPostJob
 			Access::getIdentity($this->post->getUploader())
 		];
 	}
-
-	public function requiresAuthentication()
-	{
-		return false;
-	}
-
-	public function requiresConfirmedEmail()
-	{
-		return false;
-	}
 }

src/Api/Jobs/EditPostTagsJob.php

@@ -40,14 +40,4 @@ class EditPostTagsJob extends AbstractPostJob
 			Access::getIdentity($this->post->getUploader())
 		];
 	}
-
-	public function requiresAuthentication()
-	{
-		return false;
-	}
-
-	public function requiresConfirmedEmail()
-	{
-		return false;
-	}
 }

src/Api/Jobs/EditPostThumbJob.php

@@ -27,14 +27,4 @@ class EditPostThumbJob extends AbstractPostJob
 			Access::getIdentity($this->post->getUploader())
 		];
 	}
-
-	public function requiresAuthentication()
-	{
-		return false;
-	}
-
-	public function requiresConfirmedEmail()
-	{
-		return false;
-	}
 }

src/Api/Jobs/EditPostUrlJob.php

@@ -27,14 +27,4 @@ class EditPostUrlJob extends AbstractPostJob
 			Access::getIdentity($this->post->getUploader())
 		];
 	}
-
-	public function requiresAuthentication()
-	{
-		return false;
-	}
-
-	public function requiresConfirmedEmail()
-	{
-		return false;
-	}
 }

src/Api/Jobs/FeaturePostJob.php

@@ -29,9 +29,4 @@ class FeaturePostJob extends AbstractPostJob
 	{
 		return true;
 	}
-
-	public function requiresConfirmedEmail()
-	{
-		return false;
-	}
 }

src/Api/Jobs/FlagPostJob.php

@@ -27,14 +27,4 @@ class FlagPostJob extends AbstractPostJob
 			Access::getIdentity($this->post->getUploader())
 		];
 	}
-
-	public function requiresAuthentication()
-	{
-		return false;
-	}
-
-	public function requiresConfirmedEmail()
-	{
-		return false;
-	}
 }

src/Api/Jobs/FlagUserJob.php

@@ -27,14 +27,4 @@ class FlagUserJob extends AbstractUserJob
 			Access::getIdentity($this->user)
 		];
 	}
-
-	public function requiresAuthentication()
-	{
-		return false;
-	}
-
-	public function requiresConfirmedEmail()
-	{
-		return false;
-	}
 }

src/Api/Jobs/GetLogJob.php

@@ -43,14 +43,4 @@ class GetLogJob extends AbstractPageJob
 	{
 		return Privilege::ViewLog;
 	}
-
-	public function requiresAuthentication()
-	{
-		return false;
-	}
-
-	public function requiresConfirmedEmail()
-	{
-		return false;
-	}
 }

src/Api/Jobs/GetPostContentJob.php

@@ -35,14 +35,4 @@ class GetPostContentJob extends AbstractJob
 		//temporarily enforced in execute
 		return false;
 	}
-
-	public function requiresAuthentication()
-	{
-		return false;
-	}
-
-	public function requiresConfirmedEmail()
-	{
-		return false;
-	}
 }

src/Api/Jobs/GetPostJob.php

@@ -21,14 +21,4 @@ class GetPostJob extends AbstractPostJob
 		//temporarily enforced in execute
 		return false;
 	}
-
-	public function requiresAuthentication()
-	{
-		return false;
-	}
-
-	public function requiresConfirmedEmail()
-	{
-		return false;
-	}
 }

src/Api/Jobs/GetPostThumbJob.php

@@ -44,14 +44,4 @@ class GetPostThumbJob extends AbstractJob
 		//manually enforced in execute when post is retrieved
 		return false;
 	}
-
-	public function requiresAuthentication()
-	{
-		return false;
-	}
-
-	public function requiresConfirmedEmail()
-	{
-		return false;
-	}
 }

src/Api/Jobs/ListCommentsJob.php

@@ -29,14 +29,4 @@ class ListCommentsJob extends AbstractPageJob
 	{
 		return Privilege::ListComments;
 	}
-
-	public function requiresAuthentication()
-	{
-		return false;
-	}
-
-	public function requiresConfirmedEmail()
-	{
-		return false;
-	}
 }

src/Api/Jobs/ListLogsJob.php

@@ -21,14 +21,4 @@ class ListLogsJob extends AbstractJob
 	{
 		return Privilege::ListLogs;
 	}
-
-	public function requiresAuthentication()
-	{
-		return false;
-	}
-
-	public function requiresConfirmedEmail()
-	{
-		return false;
-	}
 }

src/Api/Jobs/ListPostsJob.php

@@ -24,14 +24,4 @@ class ListPostsJob extends AbstractPageJob
 	{
 		return Privilege::ListPosts;
 	}
-
-	public function requiresAuthentication()
-	{
-		return false;
-	}
-
-	public function requiresConfirmedEmail()
-	{
-		return false;
-	}
 }

src/Api/Jobs/ListTagsJob.php

@@ -22,14 +22,4 @@ class ListTagsJob extends AbstractPageJob
 	{
 		return Privilege::ListTags;
 	}
-
-	public function requiresAuthentication()
-	{
-		return false;
-	}
-
-	public function requiresConfirmedEmail()
-	{
-		return false;
-	}
 }

src/Api/Jobs/MergeTagsJob.php

@@ -22,14 +22,4 @@ class MergeTagsJob extends AbstractJob
 	{
 		return Privilege::MergeTags;
 	}
-
-	public function requiresAuthentication()
-	{
-		return false;
-	}
-
-	public function requiresConfirmedEmail()
-	{
-		return false;
-	}
 }

src/Api/Jobs/RenameTagsJob.php

@@ -22,14 +22,4 @@ class RenameTagsJob extends AbstractJob
 	{
 		return Privilege::RenameTags;
 	}
-
-	public function requiresAuthentication()
-	{
-		return false;
-	}
-
-	public function requiresConfirmedEmail()
-	{
-		return false;
-	}
 }

src/Api/Jobs/ScorePostJob.php

@@ -19,14 +19,4 @@ class ScorePostJob extends AbstractPostJob
 			Access::getIdentity($this->post->getUploader())
 		];
 	}
-
-	public function requiresAuthentication()
-	{
-		return true;
-	}
-
-	public function requiresConfirmedEmail()
-	{
-		return false;
-	}
 }

src/Api/Jobs/TogglePostFavoriteJob.php

@@ -32,9 +32,4 @@ class TogglePostFavoriteJob extends AbstractPostJob
 	{
 		return true;
 	}
-
-	public function requiresConfirmedEmail()
-	{
-		return false;
-	}
 }

src/Api/Jobs/TogglePostTagJob.php

@@ -58,14 +58,4 @@ class TogglePostTagJob extends AbstractPostJob
 			Access::getIdentity($this->post->getUploader())
 		];
 	}
-
-	public function requiresAuthentication()
-	{
-		return false;
-	}
-
-	public function requiresConfirmedEmail()
-	{
-		return false;
-	}
 }

src/Api/Jobs/TogglePostVisibilityJob.php

@@ -27,14 +27,4 @@ class TogglePostVisibilityJob extends AbstractPostJob
 			Access::getIdentity($this->post->getUploader())
 		];
 	}
-
-	public function requiresAuthentication()
-	{
-		return true;
-	}
-
-	public function requiresConfirmedEmail()
-	{
-		return false;
-	}
 }

src/Api/Jobs/ToggleUserBanJob.php

@@ -25,14 +25,4 @@ class ToggleUserBanJob extends AbstractUserJob
 			Access::getIdentity($this->user)
 		];
 	}
-
-	public function requiresAuthentication()
-	{
-		return false;
-	}
-
-	public function requiresConfirmedEmail()
-	{
-		return false;
-	}
 }