4ba83e6834
Restored JobArgs approach. Previous introduction of hierarchic argument definitions has backfired: it was confusing what class to take arguments from, the concept of sharing arguments between different jobs was unintelligible and one never knew where given argument was actually defined. This appraoch makes it easier to maintain the arguments list and simplifies the code a lot.
116 lines
2.7 KiB
PHP
116 lines
2.7 KiB
PHP
<?php
|
|
class AddCommentJobTest extends AbstractTest
|
|
{
|
|
protected $user;
|
|
|
|
public function testSaving()
|
|
{
|
|
$this->prepare();
|
|
|
|
$text = 'alohaaaaaaa';
|
|
$comment = $this->assert->doesNotThrow(function() use ($text)
|
|
{
|
|
return $this->runApi($text);
|
|
});
|
|
$post = $comment->getPost();
|
|
|
|
$this->assert->areEqual(1, CommentModel::getCount());
|
|
$this->assert->areEqual($text, $comment->getText());
|
|
$this->assert->areEqual(Auth::getCurrentUser()->getId(), $comment->getCommenter()->getId());
|
|
$this->assert->areEqual(1, $post->getId());
|
|
$this->assert->areEqual(1, $post->getCommentCount());
|
|
$this->assert->isNotNull($comment->getCreationTime());
|
|
$this->assert->doesNotThrow(function() use ($comment)
|
|
{
|
|
CommentModel::getById($comment->getId());
|
|
});
|
|
}
|
|
|
|
public function testAlmostTooShortText()
|
|
{
|
|
$this->prepare();
|
|
$this->assert->doesNotThrow(function()
|
|
{
|
|
$this->runApi(str_repeat('b', getConfig()->comments->minLength));
|
|
});
|
|
}
|
|
|
|
public function testAlmostTooLongText()
|
|
{
|
|
$this->prepare();
|
|
$this->assert->doesNotThrow(function()
|
|
{
|
|
$this->runApi(str_repeat('b', getConfig()->comments->maxLength));
|
|
});
|
|
}
|
|
|
|
public function testTooShortText()
|
|
{
|
|
$this->prepare();
|
|
$this->assert->throws(function()
|
|
{
|
|
$this->runApi(str_repeat('b', getConfig()->comments->minLength - 1));
|
|
}, 'Comment must have at least');
|
|
}
|
|
|
|
public function testTooLongText()
|
|
{
|
|
$this->prepare();
|
|
$this->assert->throws(function()
|
|
{
|
|
$this->runApi(str_repeat('b', getConfig()->comments->maxLength + 1));
|
|
}, 'Comment must have at most');
|
|
}
|
|
|
|
public function testAnonymous()
|
|
{
|
|
$this->prepare();
|
|
$this->grantAccess('addComment');
|
|
Auth::setCurrentUser(null);
|
|
|
|
$text = 'alohaaaaaaa';
|
|
$comment = $this->assert->doesNotThrow(function() use ($text)
|
|
{
|
|
return $this->runApi($text);
|
|
});
|
|
|
|
$this->assert->areEqual($text, $comment->getText());
|
|
$this->assert->areEqual(Auth::getCurrentUser()->getId(), $comment->getCommenter()->getId());
|
|
$this->assert->areEqual(UserModel::getAnonymousName(), $comment->getCommenter()->getName());
|
|
}
|
|
|
|
public function testWrongPostId()
|
|
{
|
|
$this->prepare();
|
|
$this->grantAccess('addComment');
|
|
$this->assert->throws(function()
|
|
{
|
|
Api::run(
|
|
new AddCommentJob(),
|
|
[
|
|
JobArgs::ARG_POST_ID => 100,
|
|
JobArgs::ARG_NEW_TEXT => 'alohaa',
|
|
]);
|
|
}, 'Invalid post ID');
|
|
}
|
|
|
|
|
|
protected function runApi($text)
|
|
{
|
|
$post = $this->mockPost(Auth::getCurrentUser());
|
|
|
|
return Api::run(
|
|
new AddCommentJob(),
|
|
[
|
|
JobArgs::ARG_POST_ID => $post->getId(),
|
|
JobArgs::ARG_NEW_TEXT => $text,
|
|
]);
|
|
}
|
|
|
|
protected function prepare()
|
|
{
|
|
getConfig()->registration->needEmailForCommenting = false;
|
|
$this->grantAccess('addComment');
|
|
$this->login($this->mockUser());
|
|
}
|
|
}
|